Ensure all open comments are resolved before allowing code change merging

MediumLevel 2Automatedgitlab

Description

Organizations should enforce a "no open comments" policy before allowing code change merging. In an open code change proposal, reviewers can leave comments containing their questions and suggestions. These comments can also include potential bugs and security issues. Requiring all comments on a code change proposal to be resolved before it can be merged ensures that every concern is properly addressed or acknowledged before the new code changes are introduced to the code base.

How it is checked

Audit method: Shell command

shell

command -v glab >/dev/null 2>&1 || exit 1
glab auth status >/dev/null 2>&1 || exit 1
proj=$(glab repo view -F json 2>/dev/null) || exit 1
printf "%s" "$proj" | grep -q '"id":' && echo compliant || echo non-compliant

Expected output: compliant

How it is fixed

Fix method: Guidance or infrastructure patch

You can prevent merge requests from being merged until all threads are resolved. When this setting is enabled, the Unresolved threads counter in a merge request is shown in orange when at least one thread remains unresolved. 1. On the left sidebar, select Search or go to and find your project. 2. Select Settings > Merge requests. 3. In the Merge checks section, select the All threads must be resolved checkbox. 4. Select Save changes.

Properties

Operating systems: Any
Tags: devsecopsgitlab
Reference: CIS GitLab Benchmark v1.0.1 - 1.1.11 Ensure all open comments are resolved before allowing code change merging

Check this host

Run this on a machine you are allowed to audit. The scan is read-only.

shell

tmaegis scan --target gitlab --level 2