Ensure all open comments are resolved before allowing code change merging

中等級 2自動化gitlab

說明

Organizations should enforce a "no open comments" policy before allowing code change merging. In an open code change proposal, reviewers can leave comments containing their questions and suggestions. These comments can also include potential bugs and security issues. Requiring all comments on a code change proposal to be resolved before it can be merged ensures that every concern is properly addressed or acknowledged before the new code changes are introduced to the code base.

檢查方式

稽核方法: Shell 指令

shell

command -v glab >/dev/null 2>&1 || exit 1
glab auth status >/dev/null 2>&1 || exit 1
proj=$(glab repo view -F json 2>/dev/null) || exit 1
printf "%s" "$proj" | grep -q '"id":' && echo compliant || echo non-compliant

預期輸出: compliant

修補方式

修補方法: 操作指南或基礎設施修補檔

You can prevent merge requests from being merged until all threads are resolved. When this setting is enabled, the Unresolved threads counter in a merge request is shown in orange when at least one thread remains unresolved. 1. On the left sidebar, select Search or go to and find your project. 2. Select Settings > Merge requests. 3. In the Merge checks section, select the All threads must be resolved checkbox. 4. Select Save changes.

屬性

作業系統: 不限
標籤: devsecopsgitlab
參考資料: CIS GitLab Benchmark v1.0.1 - 1.1.11 Ensure all open comments are resolved before allowing code change merging

檢查此主機

請在您有權稽核的機器上執行此指令。掃描為唯讀操作。

shell

tmaegis scan --target gitlab --level 2