TMA-GITHUB-1.1.4

Ensure previous approvals are dismissed when updates are introduced to a code change proposal

ВысокийУровень 1Автоматическаяgithub

Описание

Ensure that when a proposed code change is updated, previous approvals are declined, and new approvals are required. An approval process is necessary when code changes are suggested. Through this approval process, however, changes can still be made to the original proposal even after some approvals have already been given. Checks the default branch: stale approvals are dismissed on new commits. Satisfied by classic branch protection or an active ruleset (rules/branches). Uses the GitHub REST/GraphQL API through gh api (read-only). The repository comes from GH_REPO or the current git checkout (gh's {owner}/{repo} resolution, GH_HOST for GitHub Enterprise Server); the organization comes from GH_ORG (default: the repository owner). Fails when gh is missing or unauthenticated (gh auth login or GH_TOKEN); organization settings and branch protection need an owner/admin token.

Как проверяется

Метод проверки: Команда оболочки

shell

command -v gh >/dev/null 2>&1 || exit 1
gh auth status >/dev/null 2>&1 || exit 1
info=$(gh api 'repos/{owner}/{repo}' --jq '.full_name + " " + .default_branch' 2>/dev/null) || exit 1
R=${info% *}; B=${info#* }
[ -n "$R" ] && [ -n "$B" ] || exit 1
p=$(gh api "repos/$R/branches/$B/protection" --jq '.required_pull_request_reviews.dismiss_stale_reviews == true' 2>/dev/null) || p=false
s=$(gh api "repos/$R/rules/branches/$B" --jq 'any(.[]; .type == "pull_request" and .parameters.dismiss_stale_reviews_on_push == true)' 2>/dev/null) || s=false
[ "$p" = true ] || [ "$s" = true ] && echo compliant

Ожидаемый вывод: compliant

Как исправляется

Метод исправления: Рекомендация или патч инфраструктуры

Settings > Branches (or Rules > Rulesets) for the default branch: enable Dismiss stale pull request approvals when new commits are pushed.

Свойства

Операционные системы: Любая
Теги: githubsource-code
Источник: CIS GitHub Benchmark v1.2.0 - 1.1.4 Ensure previous approvals are dismissed when updates are introduced to a code change proposal

Проверить этот хост

Выполните команду на компьютере, аудит которого вам разрешён. Сканирование работает только на чтение.

shell

tmaegis scan --target github